feat(engine): add ambient mcp sources - #283
Closed
andybons wants to merge 1 commit into
Closed
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$## Summary\n- add
ambient_mcp_sourcesconfig for generic MCP-provided ambient catalogs\n- validate source MCP servers after layered merge; platform/user source keys win while projects can add sources\n- fetch version-1 catalogs under a five-second deadline, cap at 256 KiB, sanitize and sort entries, then pin each source asEngineContext\n\n## Scope\nNative providers only. Claude Code delegated turns bypass the native request assembler; the documented Boxes release gate must remain off until it supports the same pinning contract. The source MCP server keeps its existingload_skilltool; this change adds no permission layer or built-in skill loader.\n\n## Verification\n-go test -race ./engine ./config ./cmd/harness -count=1\n-go vet ./...\n-go build ./...\n\nReview-only. Do not merge or deploy.